Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FacebookBridge: Better way to build title, from content #468

Closed

Conversation

pellaeon
Copy link
Contributor

@pellaeon pellaeon commented Feb 2, 2017

No description provided.

@teromene teromene added the question Indicates that an issue or pull request needs more information label Feb 2, 2017
@teromene
Copy link
Member

teromene commented Mar 8, 2017

I don't use FacebookBridge, so I can't really understand the impact it has.
Could you provide examples of better titles with your PR ?

@logmanoriginal
Copy link
Contributor

This is related to #454 which proposes another way to improve the Facebook titles. Maybe both work together?

Still, an example would be of great help in order to compare and understand the impact.

logmanoriginal pushed a commit that referenced this pull request Nov 16, 2018
A slightly improved version of #454 and #468 . Build titles from content rather than author + pre-content (which doesn't reflect anything useful).
@logmanoriginal
Copy link
Contributor

Closing because an alternative solution was implemented in the mean time. Thanks for the PR anyway!

infominer33 pushed a commit to web-work-tools/rss-bridge that referenced this pull request Apr 17, 2020
A slightly improved version of RSS-Bridge#454 and RSS-Bridge#468 . Build titles from content rather than author + pre-content (which doesn't reflect anything useful).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Indicates that an issue or pull request needs more information
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants